This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/2] Make strtok benchtest competitive
- From: Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>
- To: Ondřej Bílka <neleai at seznam dot cz>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 27 Feb 2014 18:18:17 +0530
- Subject: Re: [PATCH 1/2] Make strtok benchtest competitive
- Authentication-results: sourceware.org; auth=none
- References: <20140227123238 dot GA26291 at domone dot podge>
On 27 February 2014 18:02, OndÅej BÃlka <neleai@seznam.cz> wrote:
> Hi,
>
> One purpose of benchtests is look for regressions. For that you need to
> test implementations that have chance to be fast.
>
> A baseline is a string/function implementation. It mostly reduces
> problem to other functions that could be better optimized than
> benchmarked one and in that case we know that we need to fix it.
>
> This is a case with strtok on sse4_2 capable machines as strpbrk is
> optimized here but strtok is not. As result a current assembly strtok is
> 2-4 times slower than generic one, results on ivy_bridge below.
>
> OK to commit this benchmark?
Looks good to me.
Siddhesh