This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Fix __ASSUME_PSELECT for MicroBlaze (bug 16642)
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: <libc-alpha at sourceware dot org>, <david dot holsgrove at xilinx dot com>
- Date: Thu, 27 Feb 2014 18:34:01 +0000
- Subject: Fix __ASSUME_PSELECT for MicroBlaze (bug 16642)
- Authentication-results: sourceware.org; auth=none
Reviewing (for all architectures, with a baseline kernel version of
2.6.32) the kernel support for features for which __ASSUME_* macros
would be affected by a move to 2.6.32 as minimum kernel version showed
up that __ASSUME_PSELECT was wrongly defined for MicroBlaze, despite
the corresponding syscall table entry not being wired up in the
MicroBlaze kernel.
This patch makes the MicroBlaze kernel-features.h undefine
__ASSUME_PSELECT. I'd also encourage wiring it up in the kernel (so
you can then make this #undef conditional, and eventually obsolete
once a recent-enough kernel is required). I suspect it wasn't wired
up because of the mistaken comment in asm/unistd.h "obsolete ->
sys_pselect7" (there is no such syscall as pselect7).
2014-02-27 Joseph Myers <joseph@codesourcery.com>
[BZ #16642]
* sysdeps/unix/sysv/linux/microblaze/kernel-features.h
(__ASSUME_PSELECT): Undefine.
diff --git a/sysdeps/unix/sysv/linux/microblaze/kernel-features.h b/sysdeps/unix/sysv/linux/microblaze/kernel-features.h
index 1e9aba5..dfb8344 100644
--- a/sysdeps/unix/sysv/linux/microblaze/kernel-features.h
+++ b/sysdeps/unix/sysv/linux/microblaze/kernel-features.h
@@ -42,3 +42,6 @@
#endif
#include_next <kernel-features.h>
+
+/* The MicroBlaze kernel does not support the pselect6 syscall. */
+#undef __ASSUME_PSELECT
--
Joseph S. Myers
joseph@codesourcery.com