This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Don't include individual test ulps in libm-test-ulps
- From: Andreas Jaeger <aj at suse dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>, libc-alpha at sourceware dot org
- Date: Wed, 05 Mar 2014 09:26:24 +0100
- Subject: Re: Don't include individual test ulps in libm-test-ulps
- Authentication-results: sourceware.org; auth=none
- References: <Pine dot LNX dot 4 dot 64 dot 1403041904040 dot 5296 at digraph dot polyomino dot org dot uk>
On 03/04/2014 08:05 PM, Joseph S. Myers wrote:
> As recently discussed
> <https://sourceware.org/ml/libc-alpha/2014-02/msg00670.html>, it
> doesn't seem particularly useful for libm-test-ulps files to contain
> huge amounts of data on ulps for individual tests; just the global
> maximum observed ulps for each function, together with the
> verification of exceptions, errno and special results such as
> infinities and NaNs for each test, suffices to verify that a
> function's behavior on the given test inputs is within the expected
> accuracy. Removing this data reduces source tree churn caused by
> updates to these files when libm tests are added, and reduces the
> frequency with which testsuite additions actually need libm-test-ulps
> changes at all.
>
> Accordingly, this patch removes that data, so that individual tests
> get checked against the global bounds for the given function and only
> generate an error if those are exceeded. Tested x86_64 (including
> verifying that if an ulps value is artificially reduced, the tests do
> indeed fail as they should and "make regen-ulps" generates the
> expected changes). It's still expected for architecture maintainers
> to regenerate these files from scratch during each release freeze, but
> the diffs from such regeneration will be a lot smaller now (and so a
> lot easier to review manually for ulps that shouldn't be there,
> although I also intend to make libm-test.inc bound the ulps it outputs
> for regeneration so no such manual review is needed at all).
Let's give it a try ;)
Please review and update math/README.libm-tests for this change.
Your patch is fine with an update to the README,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126