This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] hppa: Add _STACK_GROWS_* cases to pthread_attr_[sg]etstack.
- From: Pedro Alves <palves at redhat dot com>
- To: "Carlos O'Donell" <carlos at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 05 Mar 2014 23:31:35 +0000
- Subject: Re: [PATCH] hppa: Add _STACK_GROWS_* cases to pthread_attr_[sg]etstack.
- Authentication-results: sourceware.org; auth=none
- References: <5316B1E5 dot 5070100 at redhat dot com>
I happened to skim this patch for some reason, and
noticed ...
On 03/05/2014 05:11 AM, Carlos O'Donell wrote:
> +#if _STACK_GROWS_DOWN
> iattr->stackaddr = (char *) stackaddr + stacksize;
> +#else
> + iattr->stackaddr = (char *) stackaddr;
> +#endif
> iattr->flags |= ATTR_FLAG_STACKADDR;
Used #if here.
> +#if _STACK_GROWS_DOWN
> iattr->stackaddr = (char *) stackaddr + stacksize;
> +#else
> + iattr->stackaddr = (char *) stackaddr;
> +#endif
> iattr->flags |= ATTR_FLAG_STACKADDR;
Used #if here.
> /* Store the result. */
> +#ifdef _STACK_GROWS_DOWN
> *stackaddr = (char *) iattr->stackaddr - iattr->stacksize;
> +#else
> + *stackaddr = (char *) iattr->stackaddr;
Used #ifdef here -- any particular reason for that?
--
Pedro Alves