This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2][BZ #16640] Remove strtok assembly implementation.
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: OndÅej BÃlka <neleai at seznam dot cz>, libc-alpha at sourceware dot org
- Date: Thu, 06 Mar 2014 11:20:13 -0500
- Subject: Re: [PATCH 2/2][BZ #16640] Remove strtok assembly implementation.
- Authentication-results: sourceware.org; auth=none
- References: <20140227123238 dot GA26291 at domone dot podge> <20140227124206 dot GA26474 at domone dot podge>
On 02/27/2014 07:42 AM, OndÅej BÃlka wrote:
> As followup this patch removes strtok assembly implementation as it is
> around 2-4 times slower on sse4_2 capable machines which is a majority,
> as previous benchtest demonstrated.
>
> You could try to gain some cycles on older machines by using ifuncs but
> is a strtok important enough to complicate matters?
>
> OK to commit?
>
> * sysdeps/i386/i686/strtok.S: Remove.
> * sysdeps/i386/i686/strtok_r.S: Likewise.
> * sysdeps/i386/strtok.S: Likewise.
> * sysdeps/i386/strtok_r.S: Likewise.
> * sysdeps/x86_64/strtok.S: Likewise.
> * sysdeps/x86_64/strtok_r.S: Likewise.
Is this still the case with the oldest compiler we support?
I still haven't reviewed this patch, but it's a question I had.
Cheers,
Carlos.