This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2][BZ #16640] Remove strtok assembly implementation.


On 03/13/2014 08:53 AM, Joseph S. Myers wrote:
> On Thu, 13 Mar 2014, Carlos O'Donell wrote:
> 
>> Are you saying then that the resulting code generated with gcc 4.4
>> is approximately the same performance as that generated with a
>> newer gcc, both of which are 2-4x faster than the assembly
>> implementation?
>>
>> If that's the case then please commit your patch.
> 
> Carlos, you appear to have omitted an important qualification here.  As 
> Mike noted in 
> <https://sourceware.org/ml/libc-alpha/2014-03/msg00221.html>, there needs 
> to be a proper justification for *machines without SSE4.2*.  Without such 
> a justification showing this change does not regress performance on such 
> hardware, we don't have consensus for this patch.

Joseph,

Thanks, I'd missed Mike's comments, it looks like threading didn't work
correctly for that comment.

Ondrej,

Are you able to test on a machine without SSE4.2 and describe the
performance differences?

If not, are you able to wire this up as an IFUNC for selection based
on SSSE4.2 availability?

Cheers,
Carlos.
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]