Re: [PATCH] hppa: Add _STACK_GROWS_* cases to pthread_attr_[sg]etstack.

["Carlos O'Donell" <carlos at redhat dot com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/13/2014 08:41 PM, Mike Frysinger wrote:
> On Wed 05 Mar 2014 00:11:01 Carlos O'Donell wrote:
>> This is one of a several NPTL patches to build glibc on hppa.
>>
>> The pthread_attr_[sg]etstack functions are defined by POSIX as
>> taking a stackaddr that is the lowest addressable byte of the
>> storage used for the stack. However, the internal iattr variable
>> of the same name in NPTL is actually the final stack address
>> as usable in the stack pointer for the machine. Therefore the
>> NPTL implementation must add and subtract stacksize for
>> _STACK_GROWS_DOWN architectures. HPPA is a _STACK_GROWS_UP
>> architecture and doesn't need to add or subtract anything,
>> the stack address *is* the lowest addressable byte of the
>> storage.
>>
>> Tested on hppa-linux-gnu, with no regressions.
>>
>> Can't impact any other targets because of the conditionals.
>>
>> If nobody objects I'll check this in at the end of the week.
> 
> sorry Carlos, i got impatient and fixed the #if/#ifdef and pushed it ;)

No worries. Thanks!

I have more patches queued up which I'll push directly
as long as they don't change code-gen for x86*

Cheers,
Carlos.

 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJTIlyTAAoJECXvCkNsKkr/dssIAKRp+9kt9NcO5qqgaLFeN7Sv
MC9b5rXynx1ZMspN0dvCHWbRX6wuRbSJLy8OJKdDfmcGYNAXe3ZMDZGqpEUwnrhX
ddLh6E/KwQOpUfykzTmEj31zSspi8dNqL527LAM2OfSHT4iDKYCssrGExmRh2bjk
jqVHJVQ9vTE+WjTSMZFfuZAZO7l5W/GOUYlPaH7ZimB+DMiFD4Hgwza2HmElqzq7
KbdmvZamQrJE6bEVVf9kIlt67dV0wk6+tJiZIACx99D4z0VjSA8iQotsl9WIryoK
puKVy5x/brODffioxZr/b3EuaHiQzTeUciAovK650103t/4FAWI+PhUH0Qt50aI=
=Kf7z
-----END PGP SIGNATURE-----