This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 0/3] PowerPC: remove wrong ceill implementation for PowerPC64
- From: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- To: libc-alpha at sourceware dot org
- Date: Fri, 14 Mar 2014 15:04:02 -0300
- Subject: Re: [PATCH 0/3] PowerPC: remove wrong ceill implementation for PowerPC64
- Authentication-results: sourceware.org; auth=none
- References: <53230968 dot 5020104 at linux dot vnet dot ibm dot com>
On 14-03-2014 10:51, Adhemerval Zanella wrote:
> The ceill assembly implementation (sysdeps/powerpc/powerpc64/fpu/s_ceill.S)
> returns wrong results for some inputs where first double is a exact
> integer and the precision is determined by second long double.
>
> Checking on implementation comments and history, I am very confident the
> assembly implementation was based on a version before commit
> 5c68d401698a58cf7da150d9cce769fa6679ba5f that fixes BZ#2423 (Errors in
> long double (ldbl-128ibm) rounding functions in glibc-2.4).
>
> By just removing the implementation and make the build select
> sysdeps/ieee754/ldbl-128ibm/s_ceill.c instead fixes the failing math.
>
> Fixes BZ#16701.
>
> Test on PPC64 and PPC64LE. If no one opposes it, I'll commit in a couple
> or hours.
>
> --
>
> 2014-03-14 Adhemerval Zanella <azanella@linux.vnet.ibm.com>
>
> [BZ #16701]
> * sysdeps/powerpc/powerpc64/fpu/s_ceill.S: Remove wrong
> implementation.
> * math/libm-test.inc (ceil_test_data): Add more tests.
>
Pushed as 374f7f61214967bb4e2257695aeeeecc2a77f369 with the LDBL_MANT_DIG guards.