This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 7/7] Fix HAVE_RM_CTX -Wundef warnings
- From: Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>
- To: Will Newton <will dot newton at linaro dot org>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 17 Mar 2014 19:06:01 +0530
- Subject: Re: [PATCH 7/7] Fix HAVE_RM_CTX -Wundef warnings
- Authentication-results: sourceware.org; auth=none
- References: <1395059004-20960-1-git-send-email-will dot newton at linaro dot org> <1395059004-20960-7-git-send-email-will dot newton at linaro dot org>
On 17 March 2014 17:53, Will Newton <will.newton@linaro.org> wrote:
> ChangeLog:
>
> 2014-03-17 Will Newton <will.newton@linaro.org>
>
> * sysdeps/generic/math_private.h: Check whether
> HAVE_RM_CTX is defined with #ifdef rather
> than #if.
> ---
> sysdeps/generic/math_private.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/generic/math_private.h b/sysdeps/generic/math_private.h
> index 9b881a3..0ac70e3b 100644
> --- a/sysdeps/generic/math_private.h
> +++ b/sysdeps/generic/math_private.h
> @@ -551,7 +551,7 @@ default_libc_feupdateenv_test (fenv_t *e, int ex)
> # define libc_feresetround_noexl libc_fesetenvl
> #endif
>
> -#if HAVE_RM_CTX
> +#ifdef HAVE_RM_CTX
> /* Set/Restore Rounding Modes only when necessary. If defined, these functions
> set/restore floating point state only if the state needed within the lexical
> block is different from the current state. This saves a lot of time when
> --
> 1.8.1.4
>
Looks good to me.
Thanks,
Siddhesh
--
http://siddhesh.in