This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH roland/ehdr_start] Use __ehdr_start, when available, for rtld to get its own headers.
- From: Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: "GNU C. Library" <libc-alpha at sourceware dot org>
- Date: Mon, 17 Mar 2014 22:20:02 +0530
- Subject: Re: [PATCH roland/ehdr_start] Use __ehdr_start, when available, for rtld to get its own headers.
- Authentication-results: sourceware.org; auth=none
- References: <20140311222933 dot CC24274474 at topped-with-meat dot com>
On 12 March 2014 03:59, Roland McGrath <roland@hack.frob.com> wrote:
> My motivation for this change is my NaCl port, where the old code's
> assumption about ELF file layout does not hold. But in fact this is
> not only cleaner but results in marginally better code. (To compensate
> I've added a couple of asserts. ;-)
>
> Tested on x86_64-linux-gnu:
> * with binutils-2.22 that the configure check fails and nothing changes
> * with binutils trunk (2.23 or 2.24 would do as well) that the configure
> check passes and the new code works (no 'make check' regressions)
>
> I'll commit this in a few days absent objections.
This causes a failure in check-abi-ld. It looks like the additional
symbol entry:
0000000000000000 g D .note.gnu.build-id 0000000000000000 Base
.hidden __ehdr_start
needs to either be accounted for in the abilist files or ignored in
the abilist script.
Siddhesh
--
http://siddhesh.in