This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/7] Fix __PTHREAD_MUTEX_HAVE_ELISION -Wundef warning
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 17 Mar 2014 12:53:04 -0700 (PDT)
- Subject: Re: [PATCH 1/7] Fix __PTHREAD_MUTEX_HAVE_ELISION -Wundef warning
- Authentication-results: sourceware.org; auth=none
- References: <1395059004-20960-1-git-send-email-will dot newton at linaro dot org> <20140317182818 dot 5EAD474457 at topped-with-meat dot com> <20140317183732 dot C5A2374458 at topped-with-meat dot com> <532749D3 dot 3080008 at linux dot vnet dot ibm dot com>
> For 788bba368c2eaf8aa3fd2ca18d269395d6bc8afb I still think the ifdef for
> __PTHREAD_MUTEX_HAVE_ELISION is the way to go, since it fallows the
> __PTHREAD_MUTEX_HAVE_PREV logic already in place and avoid adds another
> default header or add more arch specific logic for arch that do not
> support it.
Someone should audit all the related #if logic and describe what it's
doing. Then we can consider how best to rework it to be typo-proof.