This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH roland/mman-linux] Move bits/mman-linux.h out of sysdeps/unix/sysv/linux/.
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: "GNU C. Library" <libc-alpha at sourceware dot org>
- Date: Tue, 18 Mar 2014 19:27:33 -0400
- Subject: Re: [PATCH roland/mman-linux] Move bits/mman-linux.h out of sysdeps/unix/sysv/linux/.
- Authentication-results: sourceware.org; auth=none
- References: <20140314200309 dot 83A247449E at topped-with-meat dot com> <5323754A dot 3020505 at redhat dot com> <20140318215206 dot 2145274483 at topped-with-meat dot com>
On 03/18/2014 05:52 PM, Roland McGrath wrote:
>> Every other way I can think of organizing the header, include_next, or
>> something else, just looks uglier than moving the header. So your solution
>> seems like the most reasonable.
>
> I also had a hack where sysdeps/.../Makefile just copied the source file to
> the build directory. That works well enough and avoids nastiness inside
> the file itself. But it's less clean than moving the file.
It always irritates me when other build systems do this as it makes it
harder to understand the entirety of the source without having a build
directory. At present we do a pretty good job of keeping the source
structured such that you can read it and understand what it should do.
>> On request. Add enough comments that we know why this file is there so
>> someone reading either Makefile's or the header itself knows why it's
>> not where it should be.
>
> I forgot about this request before I pushed the change.
> I'll add some comments now.
Thanks.
Cheers,
Carlos.