This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] [ARM] Add fenv test support for targets which don't have FP traps
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Wilco <wdijkstr at arm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 19 Mar 2014 17:40:21 +0000
- Subject: Re: [PATCH] [ARM] Add fenv test support for targets which don't have FP traps
- Authentication-results: sourceware.org; auth=none
- References: <000101cf4392$529cd5d0$f7d68170$ at com>
On Wed, 19 Mar 2014, Wilco wrote:
> +/* Indicate whether the given exception trap(s) can be enabled
> + in feenableexcept. All traps are supported unless overridden. */
> +#ifndef EXCEPTION_ENABLE_SUPPORTED
> +# define EXCEPTION_ENABLE_SUPPORTED(EXCEPT) \
> + (EXCEPTION_TESTS_float || EXCEPTION_TESTS_double)
> +#endif
I think the comment needs to make the definition clearer (that a nonzero
value means the traps are definitely supported, but a zero value means
they might or might not be supported and this is determined at runtime
with enabling traps being allowed to fail).
--
Joseph S. Myers
joseph@codesourcery.com