This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/7] Fix __PTHREAD_MUTEX_HAVE_ELISION -Wundef warning
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>, <libc-alpha at sourceware dot org>
- Date: Thu, 20 Mar 2014 18:31:31 +0000
- Subject: Re: [PATCH 1/7] Fix __PTHREAD_MUTEX_HAVE_ELISION -Wundef warning
- Authentication-results: sourceware.org; auth=none
- References: <1395059004-20960-1-git-send-email-will dot newton at linaro dot org> <20140317182818 dot 5EAD474457 at topped-with-meat dot com> <20140317183732 dot C5A2374458 at topped-with-meat dot com> <532749D3 dot 3080008 at linux dot vnet dot ibm dot com> <20140317195304 dot 3AA2174461 at topped-with-meat dot com> <53283BD1 dot 1020000 at linux dot vnet dot ibm dot com> <20140318224608 dot 0B68B7447C at topped-with-meat dot com> <Pine dot LNX dot 4 dot 64 dot 1403182321420 dot 27957 at digraph dot polyomino dot org dot uk> <20140320175228 dot 2A37D7449B at topped-with-meat dot com>
On Thu, 20 Mar 2014, Roland McGrath wrote:
> > Typo-proofing also provides another case for replacing the __need_*
> > scheme, as I suggested in
> > <https://sourceware.org/ml/libc-alpha/2012-08/msg00510.html> and
> > <https://sourceware.org/ml/libc-alpha/2012-11/msg00045.html>, so that we
> > do
> >
> > #include <bits/time_t.h>
> >
> > instead of
> >
> > #define __need_time_t
> > #include <time.h>
> >
> > (the former being typo-proof, the latter not).
>
> I didn't recall you suggesting that, but it's been on my list for some
> time. (I think we should use a convention other than plain bits/, but
> that's just trivia.)
Note that for the cases of
#define __need_size_t
#include <stddef.h>
and other cases involving stddef.h, an improvement would require new
separate headers to be installed by GCC, so that glibc's header for size_t
could do
#if __GNUC_PREREQ (whatever)
# include <gcc-size_t.h>
#else
# define __need_size_t
# include <stddef.h>
#endif
or similar.
--
Joseph S. Myers
joseph@codesourcery.com