This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] benchtests/bench-strtod.c: Increase timeout value


On Tue, Mar 25, 2014 at 04:13:19PM +0000, Will Newton wrote:
> This benchmark can take longer than the default 2 seconds on slower
> platforms, so increase it to 10 seconds.
> 
> ChangeLog:
> 
> 2014-03-25  Will Newton <will.newton@linaro.org>
> 
> 	* benchtests/bench-strtod.c (TIMEOUT): Define to 10.
> ---
>  benchtests/bench-strtod.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/benchtests/bench-strtod.c b/benchtests/bench-strtod.c
> index fbe8040..d0c4922 100644
> --- a/benchtests/bench-strtod.c
> +++ b/benchtests/bench-strtod.c
> @@ -26,6 +26,9 @@
>  #undef INNER_LOOP_ITERS
>  #define INNER_LOOP_ITERS 65536
>  
> +/* On slower platforms this test needs more than the default 2 seconds.  */
> +#define TIMEOUT 10
> +
>  static const char *inputs[] =
>  {
>    "1e308",

The usual practice seems to be to put the TIMEOUT macro definition
just before including test-skeleton.c, but that's a minor detail.  The
change looks OK to me.

Thanks,
Siddhesh

Attachment: pgpNSLXjGtWaT.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]