This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/2] Separate ftell from fseek logic and avoid modifying FILE data (#16532)

From: Siddhesh Poyarekar <siddhesh at redhat dot com>
To: Andreas Schwab <schwab at suse dot de>
Cc: "Carlos O'Donell" <carlos at redhat dot com>, libc-alpha at sourceware dot org
Date: Tue, 25 Mar 2014 17:20:32 +0530
Subject: Re: [PATCH 1/2] Separate ftell from fseek logic and avoid modifying FILE data (#16532)
Authentication-results: sourceware.org; auth=none
References: <20140220172904 dot GC16378 at spoyarek dot pnq dot redhat dot com> <53150D21 dot 6090104 at redhat dot com> <20140304031330 dot GJ1722 at spoyarek dot pnq dot redhat dot com> <mvmeh1qmrje dot fsf at hawking dot suse dot de>

On Tue, Mar 25, 2014 at 12:44:21PM +0100, Andreas Schwab wrote:
> > -	tst-fwrite-error tst-ftell-partial-wide
> > +	tst-fwrite-error tst-ftell-partial-wide tst-ftell-active-handler
> >  ifeq (yes,$(build-shared))
> >  # Add test-fopenloc only if shared library is enabled since it depends on
> >  # shared localedata objects.
> 
> You need to set up LOCPATH so that the tests can find their locales.
> Installed as obvious.

Thanks!

I wonder if it would be useful to set LOCPATH all the time so that we
don't have to bother with doing it for individual tests.

Siddhesh

Attachment: pgpMkULVe_0ve.pgp
Description: PGP signature

Follow-Ups:
- Re: [PATCH 1/2] Separate ftell from fseek logic and avoid modifying FILE data (#16532)
  - From: Mike Frysinger

References:
- Re: [PATCH 1/2] Separate ftell from fseek logic and avoid modifying FILE data (#16532)
  - From: Carlos O'Donell
- Re: [PATCH 1/2] Separate ftell from fseek logic and avoid modifying FILE data (#16532)
  - From: Siddhesh Poyarekar
- Re: [PATCH 1/2] Separate ftell from fseek logic and avoid modifying FILE data (#16532)
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]