This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH 2/N, MPX, x86_64] Intel MPX support in glibc for x86_64



> -----Original Message-----
> From: Ondřej Bílka [mailto:neleai@seznam.cz]
> Sent: Monday, March 24, 2014 1:00 PM
> To: Zamyatin, Igor
> Cc: libc-alpha@sourceware.org; hjl.tools@gmail.com
> Subject: Re: [PATCH 2/N, MPX, x86_64] Intel MPX support in glibc for x86_64
> 
> On Tue, Mar 18, 2014 at 02:22:40PM +0000, Zamyatin, Igor wrote:
> > Hi All!
> >
> > Attached patch continues (see the beginning here -
> http://sourceware.org/ml/libc-alpha/2014-03/msg00491.html) adding
> support for Intel MPX in Glibc for x86_64. Current change performs storing
> and restoring of bound registers before and after _dl_profile_fixup call.
> >
> > Is it ok to install?
> >
> This part looks ok. Do these matter also in lazy tls resolving, see
> sysdeps/x86_64/dl-tlsdesc.S

Seems, no, changes in dl-trampoline are enough for correct storing/restoring of bound registers

Thanks,
Igor

> 
> I had patch to unify these so I could rehash it.
> 
> > 2014-03-18  Igor Zamyatin  <igor.zamyatin@intel.com>
> >
> > 	* sysdeps/x86_64/bits/link.h (La_x86_64_regs): Add lr_bnd.
> > 	(La_x86_64_retval): Add lrv_bnd0 and lrv_bnd1.
> > 	* sysdeps/x86_64/dl-trampoline.S (_dl_runtime_profile): Add
> preserving
> > 	of the Intel MPX bound registers before call of _dl_profile_fixup.
> > 	* sysdeps/x86_64/dl-trampoline.h: Add restoring of the Intel MPX
> bound
> > 	registers after call of _dl_profile_fixup.
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]