This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Updated rwlock-in-C patchkit
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Torvald Riegel <triegel at redhat dot com>, Andi Kleen <andi at firstfloor dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Sat, 12 Apr 2014 13:23:32 -0400
- Subject: Re: Updated rwlock-in-C patchkit
- Authentication-results: sourceware.org; auth=none
- References: <1395789863-5026-1-git-send-email-andi at firstfloor dot org> <1397248605 dot 10643 dot 18269 dot camel at triegel dot csb>
On 04/11/2014 04:36 PM, Torvald Riegel wrote:
> On Tue, 2014-03-25 at 16:24 -0700, Andi Kleen wrote:
>> Fixed the ChangeLog as requested. Otherwise no changes.
>>
>> Please consider merging.
>
> Based on a quick scan this looks good to me, and I definitely like the
> direction. However, I believe this won't get accepted unless you show
> numbers by providing a benchtest for the uncontended case.
Fully agreed.
While I trust that you think it's faster I would like an objective way
to measure this on the systems that I care about.
Please provide a microbenchmark that shows this to be the case. That way
we can include it in our regular testing and distributions can ensure
that the performance stays consistent across releases, compilers, etc.
Cheers,
Carlos.