This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH roland/arm-unwind-header] Move ARM internal unwind.h header to the right sysdeps directory.
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: "GNU C. Library" <libc-alpha at sourceware dot org>
- Date: Tue, 6 May 2014 22:08:30 +0000
- Subject: Re: [PATCH roland/arm-unwind-header] Move ARM internal unwind.h header to the right sysdeps directory.
- Authentication-results: sourceware.org; auth=none
- References: <20140505225633 dot E56292C39D2 at topped-with-meat dot com>
On Mon, 5 May 2014, Roland McGrath wrote:
> This is a trivial file renaming, so I'm not including a real patch, just
> the 'git apply' flavored one.
>
> unwind.h contains nothing actually specific to Linux, let alone to NPTL.
> It's required by sysdeps/arm/backtrace.c, so it should be in a sysdeps
> location that is accessible to all configurations building that file.
>
> The file itself appears to be a quite old copy of the file from GCC (which
> has since changed its name in GCC sources), complete with wrong copyright
> header (which has an exception and so should be legally adequate, but
> probably not what we'd do today). AFAICT much of what's there is not
> actually used anywhere in libc, so it is probably better to prune the file
> down rather than to try to keep it in sync with the modern GCC file. (In
> particular the _Unwind_decode_target2 function is troubling, because it
> uses #ifdef deeply wrongly for code living in libc. But that function is
> wholly unused.) But that's cleanup for another day.
>
> OK?
OK.
--
Joseph S. Myers
joseph@codesourcery.com