This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RESEND][BZ #15132][PATCH] avoid stat/fstat in statvfs/fstatvfs

From: Siddhesh Poyarekar <siddhesh at redhat dot com>
To: Eric Wong <normalperson at yhbt dot net>
Cc: OndÅej BÃlka <neleai at seznam dot cz>, libc-alpha at sourceware dot org
Date: Thu, 29 May 2014 09:47:04 +0530
Subject: Re: [RESEND][BZ #15132][PATCH] avoid stat/fstat in statvfs/fstatvfs
Authentication-results: sourceware.org; auth=none
References: <20140125220000 dot GA19098 at dcvr dot yhbt dot net> <20140127050402 dot GC2149 at spoyarek dot pnq dot redhat dot com> <20140204181702 dot GA25215 at dcvr dot yhbt dot net> <20140221114609 dot GA7772 at domone dot podge> <20140222063909 dot GA6861 at dcvr dot yhbt dot net> <20140527060814 dot GA28198 at dcvr dot yhbt dot net>

On Tue, May 27, 2014 at 06:08:14AM +0000, Eric Wong wrote:
> I tested with the above patch applied 3.14 kernel and verified it
> correctly falls back to using stat/fstat if the ST_VALID flag is
> missing.
> 
> On an unpatched 3.14 kernel, the same executables/binaries avoid
> stat/fstat when statvfs/fstatvfs are called.
> 
> I straced the following program to verify the presence/lack-of
> extraneous stat/fstat syscalls after statfs/fstatfs:
> 
>   strace /path/to/lib/ld-linux-x86-64.so.2 /tmp/statvfs
> 

I have pushed the patch into master.  Thank you for following up on
this!

Siddhesh

Attachment: pgpwR0_A0pB2_.pgp
Description: PGP signature

References:
- Re: [RESEND][BZ #15132][PATCH] avoid stat/fstat in statvfs/fstatvfs
  - From: Eric Wong

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]