This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH roland/nptl-sh] SH: Consolidate NPTL/non versions of vfork
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 30 May 2014 09:19:57 -0700 (PDT)
- Subject: Re: [PATCH roland/nptl-sh] SH: Consolidate NPTL/non versions of vfork
- Authentication-results: sourceware.org; auth=none
- References: <20140529230926 dot 133C22C3C21 at topped-with-meat dot com> <20140530 dot 134750 dot 439128275 dot kkojima at rr dot iij4u dot or dot jp>
> vfork.S part works as expected in my environment.
Great.
> > --- /dev/null
> > +++ b/sysdeps/unix/sysv/linux/sh/pt-vfork.S
> [snip]
> > +#if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_20)
> > +# include <vfork.S>
> > +
> > +compat_symbol (__vfork, __vfork, GLIBC_2_0)
> > +compat_symbol (vfork, vfork, GLIBC_2_0)
> > +#endif
>
> I thought that pt-vfork.S is for libpthread.so and
> it would be
>
> #if SHLIB_COMPAT (libpthread, GLIBC_2_0, GLIBC_2_20)
> # include <vfork.S>
>
> compat_symbol (libpthread, __vfork, __vfork, GLIBC_2_0)
> compat_symbol (libpthread, vfork, vfork, GLIBC_2_0)
> #endif
>
> Am I missing something here?
Nope. You are correct. It's easy to forget these little details when you
don't bother trying to compile it. ;-)
I've made that fix on the branch. Please let me know if it works now.
(Or feel free to just commit it yourself if you prefer.)
Thanks,
Roland