This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] aarch64: Move remaining sysdeps/unix/sysv/linux/aarch64/nptl/ files
- From: Chris Metcalf <cmetcalf at tilera dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: Richard Henderson <rth at twiddle dot net>, <libc-alpha at sourceware dot org>, <marcus dot shawcroft at arm dot com>, Richard Henderson <rth at redhat dot com>
- Date: Tue, 10 Jun 2014 14:15:10 -0400
- Subject: Re: [PATCH] aarch64: Move remaining sysdeps/unix/sysv/linux/aarch64/nptl/ files
- Authentication-results: sourceware.org; auth=none
- References: <1401818095-15788-1-git-send-email-rth at twiddle dot net> <20140603180526 dot 9CA032C3A18 at topped-with-meat dot com> <5390945C dot 2010303 at twiddle dot net> <5390976C dot 2010603 at tilera dot com> <20140605184326 dot E2D292C39BD at topped-with-meat dot com>
On 6/5/2014 2:43 PM, Roland McGrath wrote:
Using sysdeps/unix/sysv/linux/ARCH/ here is an acceptable intermediate
step. There are really two separate things going on here:
1. De-add-on-ization of NPTL.
To do just this, using sysdeps/unix/sysv/linux/ARCH/ makes sense and
is the least change from the status quo.
2. De-Linux-ization of NPTL code containing no actual Linuxisms.
Assuming each bits/ file actually contains no Linuxisms, then
using sysdeps/ARCH/nptl/ accomplishes one tiny piece of this work.
#1 is what requires action from every machine maintainer. For #2 I'll be
able to proceed piecemeal with each architecture I'm actually paying
attention to for a non-Linux NPTL port, which is just ARM to begin with and
later will include x86.
So if you want to vet the bits/ files and verify there are no creeping
Linuxisms in there, then moving them to sysdeps/ARCH/nptl now is great.
But if you want to think about it less and just move them to
sysdeps/unix/sysv/linux/ARCH/, that is just fine too.
I took option #2 since the tile headers were pretty similar to the existing x86.
Roland, my moving createthread.c will now mean you'll have a merge issue with your change to delete it in favor of the new #define in tls.h; sorry about that.
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com