This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH, AArch64] Add optimized strchr.
- From: Will Newton <will dot newton at linaro dot org>
- To: Richard Earnshaw <rearnsha at arm dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Tue, 17 Jun 2014 11:37:26 +0100
- Subject: Re: [PATCH, AArch64] Add optimized strchr.
- Authentication-results: sourceware.org; auth=none
- References: <53983583 dot 3040606 at arm dot com>
On 11 June 2014 11:54, Richard Earnshaw <rearnsha@arm.com> wrote:
Hi Richard,
> Implementation of strchr for AArch64. Speedups taken from micro-bench
> show the improvements relative to the standard C code.
>
> The use of LD1 means we have identical code for both big- and
> little-endian systems.
>
> A speedup (which is taken as the time to run the reference version
> divided by the time to run the new version) >1 implies an improvement
> (<1 a regression). The table only shows one sample that regresses and
> that's by marginally less than 1%. The geomean for all the samples is
> 1.58.
>
> Measurements are on Cortex-A57.
>
> <date> Richard Earnshaw <rearnsha@arm.com>
>
> * sysdeps/aarch64/strchr.S: New file.
>
> OK?
Some of the indentation around the defines of tmp1 and vrepchr seems a
bit off, but other than that this looks OK.
--
Will Newton
Toolchain Working Group, Linaro