This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] stdlib/tst-qsort2.c: Fix off-by-one argc interpretation error


On Sat, 5 Oct 2013, Ondřej Bílka wrote:

> >  This fixes an off-by-one argc interpretation error (argv[0] is included 
> > in the count) in stdlib/tst-qsort2.c causing a segfault if the program is 
> > called with one command-line argument only (argv[2] is NULL in that case).  
> > 
> >  The issue doesn't trigger in regular testing as the test case is invoked 
> > without arguments in the test suite, but that doesn't mean the bug is good 
> > to have.  OK to apply?
> >
> Looks obvious for me.
> 
> > 2013-10-04  Maciej W. Rozycki  <macro@codesourcery.com>
> > 
> > 	* stdlib/tst-qsort2.c (main): Fix off-by-one argc interpretation 
> > 	error.

 Thanks for your review.  Committed now, apologies for the delay.

  Maciej


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]