This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix Wundef warning for MEMCPY_OK_FOR_FWD_MEMMOVE
- From: Will Newton <will dot newton at linaro dot org>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: Roland McGrath <roland at hack dot frob dot com>, libc-alpha <libc-alpha at sourceware dot org>
- Date: Fri, 27 Jun 2014 10:28:21 +0100
- Subject: Re: [PATCH] Fix Wundef warning for MEMCPY_OK_FOR_FWD_MEMMOVE
- Authentication-results: sourceware.org; auth=none
- References: <20140626185412 dot GA1826 at spoyarek dot pnq dot redhat dot com> <20140626190423 dot 572732C3993 at topped-with-meat dot com> <20140627092109 dot GD4477 at spoyarek dot pnq dot redhat dot com>
On 27 June 2014 10:21, Siddhesh Poyarekar <siddhesh@redhat.com> wrote:
> On Thu, Jun 26, 2014 at 12:04:23PM -0700, Roland McGrath wrote:
>> That only helps x86_64 and not anybody else using that file (whether
>> directly by sysdeps selection or by #include). I think memcopy.h should
>> be required to define that one way or the other. Then we can have a
>> default in sysdeps/generic/memcopy.h.
>
> Wouldn't that not catch cases where one forgets to define the macro
> and inherits the default?
It's an optimization hint so it should be ok to inherit the default of
"use the slow copy loop".
--
Will Newton
Toolchain Working Group, Linaro