This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Fix Wundef warning for MEMCPY_OK_FOR_FWD_MEMMOVE
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: Chris Metcalf <cmetcalf at tilera dot com>, Will Newton <will dot newton at linaro dot org>, libc-alpha <libc-alpha at sourceware dot org>
- Date: Fri, 27 Jun 2014 21:26:05 -0700 (PDT)
- Subject: Re: [PATCH v2] Fix Wundef warning for MEMCPY_OK_FOR_FWD_MEMMOVE
- Authentication-results: sourceware.org; auth=none
- References: <20140626185412 dot GA1826 at spoyarek dot pnq dot redhat dot com> <20140626190423 dot 572732C3993 at topped-with-meat dot com> <20140627092109 dot GD4477 at spoyarek dot pnq dot redhat dot com> <CANu=Dmi2W9jK8+jjtSms3Y0KTuY20UnvLTz_0iTOOYnedT0uzg at mail dot gmail dot com> <20140627171326 dot GE4477 at spoyarek dot pnq dot redhat dot com> <53ADD391 dot 2030803 at tilera dot com> <20140628004821 dot GK4477 at spoyarek dot pnq dot redhat dot com>
> --- a/sysdeps/generic/memcopy.h
> +++ b/sysdeps/generic/memcopy.h
> @@ -148,4 +148,6 @@ extern void _wordcopy_bwd_dest_aligned (long int, long int, size_t) __THROW;
> /* Threshold value for when to enter the unrolled loops. */
> #define OP_T_THRES 16
>
> +#define MEMCPY_OK_FOR_FWD_MEMMOVE 0
This name is pretty self-explanatory, but as a general rule a
sysdeps/generic file like should have copious comments that make clear what
the protocol for other sysdeps variants is and what each symbol means.