This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] un-nest findidx()
- From: Konstantin Serebryany <konstantin dot s dot serebryany at gmail dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: Roland McGrath <roland at hack dot frob dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 3 Jul 2014 17:01:27 +0400
- Subject: Re: [PATCH] un-nest findidx()
- Authentication-results: sourceware.org; auth=none
- References: <CAGQ9bdz9V7w+5Wn_j8CSKvweh9GkW0gU5GvB94UCP2Zn-bf8OQ at mail dot gmail dot com> <mvm38ei1wad dot fsf at hawking dot suse dot de> <CAGQ9bdw3dJWHsgxgf22F5HEa09VX8gDKeFN-GQuRm-ymcJMZ-Q at mail dot gmail dot com> <mvmlhsazl00 dot fsf at hawking dot suse dot de>
On Thu, Jul 3, 2014 at 4:26 PM, Andreas Schwab <schwab@suse.de> wrote:
> Konstantin Serebryany <konstantin.s.serebryany@gmail.com> writes:
>
>> On Thu, Jul 3, 2014 at 4:06 PM, Andreas Schwab <schwab@suse.de> wrote:
>>> Konstantin Serebryany <konstantin.s.serebryany@gmail.com> writes:
>>>
>>>> (FCT): change type of 'extra' to wint_t;
>>>
>>> Why do you need this change?
>> To avoid warnings about different types of argument and parameter
>
> But why do you have that conflict in the first place? You must use the
> type of the object in the end.
There are multiple uses of findidxwc. Some were using int32_t* for
'extra', some where using wint_t*
(e.g. see USTRING_TYPE in wcsmbs/wcscoll.c).
When un-nesting findidxwc we have to chose just one type. I chose
wint_t because otherwise the change would have been larger.
--kcc
>
> Andreas.
>
> --
> Andreas Schwab, SUSE Labs, schwab@suse.de
> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
> "And now for something completely different."