This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Distributions still suffering from s390 ABI change problems.
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>, Aurelien Jarno <aurelien at aurel32 dot net>
- Cc: Jeff Law <law at redhat dot com>, David Miller <davem at davemloft dot net>, krebbel at linux dot vnet dot ibm dot com, roland at hack dot frob dot com, allan at archlinux dot org, libc-alpha at sourceware dot org
- Date: Tue, 15 Jul 2014 11:48:33 -0400
- Subject: Re: Distributions still suffering from s390 ABI change problems.
- Authentication-results: sourceware.org; auth=none
- References: <53C43A5E dot 9020304 at redhat dot com> <20140714 dot 132444 dot 140785163900092398 dot davem at davemloft dot net> <53C440FF dot 3010308 at redhat dot com> <20140714 dot 140948 dot 808129071568411651 dot davem at davemloft dot net> <53C449C0 dot 50709 at redhat dot com> <53C4C14E dot 30908 at redhat dot com> <20140715074223 dot GC32518 at hall dot aurel32 dot net> <20140715084921 dot GF17822 at spoyarek dot pnq dot redhat dot com> <20140715095838 dot GL1239 at hall dot aurel32 dot net> <20140715102334 dot GG17822 at spoyarek dot pnq dot redhat dot com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 07/15/2014 06:23 AM, Siddhesh Poyarekar wrote:
> On Tue, Jul 15, 2014 at 11:58:38AM +0200, Aurelien Jarno wrote:
>> In addition understanding why this structure has to be extended instead
>> of "needed for future hardware" might help to really understand the
>> problem and look for alternative solutions.
>
> A quick reading of the offending patch seems to indicate that it is
> just a buffer extension in preparation for future hardware support,
> i.e. all that the new code seems to do is to set the added field to 0,
> in addition to adding some compat code for versioning. Given that
> we're not going to have the future hardware support in 2.20 (slushy
> freeze and all), maybe we should push this to 2.21 and fix the ABI in
> 2.20.
>
> Unless of course, it is evident that there is absolutely no way to
> introduce the new hardware support that Andreas alluded to without
> breaking ABI...
Fundamentally this is not our decision to make. Andreas Krebbel is the
machine maintainer and has the final say on when and how the ABI should
be changed for s390.
As an FSF Steward for the GNU C Library project I can suggest a strong
course of action here, but Andreas has the final word.
Given that the damage is done in 2.19, backing it out now is not a good
idea. We just have to move forward. I would not condone reverting the
changes given that 2.19 is already out the door.
We should:
* Fix the pthread issues.
* Work to provide tooling warnings for future ABI issues.
Cheers,
Carlos.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJTxU1RAAoJECXvCkNsKkr/AygIAM64TISCEHh4jPSFi2Xy+gx+
FvoYPnREiVev+N2GH/Snc86TA3umMDLKXglCH0QBnNAWux0n+6DkJrbVBS0Y4Xm+
ivGe1X66gPpvfdtwwFsmXezHTcTcx+bL651hZgdOiGKyJi0ifGdrWmwM0HykBhaU
8CJx6IE3Cx5wN6/+D6vvEMgsBidfvRBLSKMQXzq5wbZ3INol7Tpd6qzCBRwKQtIm
gNIXHMSif+/pyu8UAH2Nh/uhVyDGrQp1naR8l61M66Z7j6RStK3H5lOPvFeExp/j
mpkRvChPWwrxRvtX5SclpqQLDPMMJ6IJGXmPiXvCH9VrtJn0wCdXFRt4Jvbjg5o=
=A9mX
-----END PGP SIGNATURE-----