This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 5/5] obstack usability

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Alan Modra <amodra at gmail dot com>, Andreas Schwab <schwab at linux-m68k dot org>
Cc: bug-gnulib at gnu dot org, libc-alpha at sourceware dot org
Date: Sat, 26 Jul 2014 07:49:05 -0400
Subject: Re: [PATCH 5/5] obstack usability
Authentication-results: sourceware.org; auth=none
References: <1406354233-7664-1-git-send-email-amodra at gmail dot com> <1406354233-7664-6-git-send-email-amodra at gmail dot com> <m261iksi0r dot fsf at linux-m68k dot org> <20140726112138 dot GD15767 at bubble dot grove dot modra dot org>

On 07/26/2014 07:21 AM, Alan Modra wrote:

> >+#   elif defined _MSC_VER && 1200 <= _MSC_VER

>
>Please write that as "_MSC_VER >= 1200".

Thanks for looking over the patch.  This line was taken out of
gnulib/m4/gnulib-common.m4..

I'm happy to fix this oddity and others like it,

I'd rather leave this alone. This is a long-running disagreement abouta minor style issue, and there's no need to impose the other style here.

Follow-Ups:
- Re: [PATCH 5/5] obstack usability
  - From: Andreas Schwab

References:
- [PATCH 0/5] obstacks
  - From: Alan Modra
- [PATCH 5/5] obstack usability
  - From: Alan Modra
- Re: [PATCH 5/5] obstack usability
  - From: Andreas Schwab
- Re: [PATCH 5/5] obstack usability
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]