This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 5/5] obstack usability


Paul Eggert <eggert@cs.ucla.edu> writes:

> On 07/26/2014 07:21 AM, Alan Modra wrote:
>>>> > >+#   elif defined _MSC_VER && 1200 <= _MSC_VER
>>> >
>>> >Please write that as "_MSC_VER >= 1200".
>> Thanks for looking over the patch.  This line was taken out of
>> gnulib/m4/gnulib-common.m4..
>>
>> I'm happy to fix this oddity and others like it,
> I'd rather leave this alone.  This is a long-running disagreement about a
> minor style issue, and there's no need to impose the other style here.

This style is not suitable for high quality software.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]