This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 5/5] obstack usability
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: Paul Eggert <eggert at cs dot ucla dot edu>
- Cc: Alan Modra <amodra at gmail dot com>, bug-gnulib at gnu dot org, libc-alpha at sourceware dot org
- Date: Sat, 26 Jul 2014 14:17:23 +0200
- Subject: Re: [PATCH 5/5] obstack usability
- Authentication-results: sourceware.org; auth=none
- References: <1406354233-7664-1-git-send-email-amodra at gmail dot com> <1406354233-7664-6-git-send-email-amodra at gmail dot com> <m261iksi0r dot fsf at linux-m68k dot org> <20140726112138 dot GD15767 at bubble dot grove dot modra dot org> <53D395B1 dot 5090000 at cs dot ucla dot edu>
Paul Eggert <eggert@cs.ucla.edu> writes:
> On 07/26/2014 07:21 AM, Alan Modra wrote:
>>>> > >+# elif defined _MSC_VER && 1200 <= _MSC_VER
>>> >
>>> >Please write that as "_MSC_VER >= 1200".
>> Thanks for looking over the patch. This line was taken out of
>> gnulib/m4/gnulib-common.m4..
>>
>> I'm happy to fix this oddity and others like it,
> I'd rather leave this alone. This is a long-running disagreement about a
> minor style issue, and there's no need to impose the other style here.
This style is not suitable for high quality software.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."