This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH-for-2.21-and-2.22] s390-64: remove socketcall syscalls
- From: Arnd Bergmann <arnd at arndb dot de>
- To: libc-alpha at sourceware dot org
- Cc: Aurelien Jarno <aurelien at aurel32 dot net>, Stefan Liebler <stli at linux dot vnet dot ibm dot com>, Geert Uytterhoeven <geert at linux-m68k dot org>, Greg Ungerer <gerg at uclinux dot org>, Andy Lutomirski <luto at kernel dot org>
- Date: Tue, 29 Dec 2015 10:18:20 +0100
- Subject: Re: [PATCH-for-2.21-and-2.22] s390-64: remove socketcall syscalls
- Authentication-results: sourceware.org; auth=none
- References: <1451010098-22120-1-git-send-email-aurelien at aurel32 dot net>
On Friday 25 December 2015 03:21:38 Aurelien Jarno wrote:
> From: Stefan Liebler <stli@linux.vnet.ibm.com>
>
> Remove socketcalls in syscalls.list for s390-64. They were never used
> on s390x and produce wrong code when glibc is built against 4.3 kernel
> headers.
>
> ChangeLog:
>
> * sysdeps/unix/sysv/linux/s390/s390-64/syscalls.list:
> Remove socketcall syscalls.
>
> (partially cherry picked from commit 016495b818cb61df7d0d10e6db54074271b3e3a5)
> ---
> ChangeLog | 5 +++++
> sysdeps/unix/sysv/linux/s390/s390-64/syscalls.list | 19 -------------------
> 2 files changed, 5 insertions(+), 19 deletions(-)
>
> This is a partial backport of commit 016495b8 which is already on master
> and is needed when building glibc against 4.3+ kernel headers. Otherwise
> we end up with wrong code, like this one for socket:
Hi Stefan,
Can you explain what exactly went wrong? I see that the same change that
was done in the kernel headers also made it into the m68k and x86
architectures:
Author: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Sun Sep 6 11:59:27 2015 +0200
m68k: Wire up direct socket calls
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Greg Ungerer <gerg@uclinux.org>
commit 9dea5dc921b5f4045a18c63eb92e84dc274d17eb
Author: Andy Lutomirski <luto@kernel.org>
Date: Tue Jul 14 15:24:24 2015 -0700
x86/entry/syscalls: Wire up 32-bit direct socket calls
Do those have the same problem? Is there a way to avoid the problem for
other architectures that want to add the separate calls later?
Arnd