This is the mail archive of the libc-hacker@sourceware.cygnus.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: build overhaul [PATCH]



This patch fixes the bug.

zw

Sun May 31 11:10:52 1998  Zack Weinberg  <zack@rabi.phys.columbia.edu>

	* Makerules (lib%.so): Move rule...
	* extra-lib.mk: ...here, and make it just for $(lib).

============================================================
Index: Makerules
--- Makerules	Sat, 30 May 1998 18:37:27 -0400 zack  Z.6
+++ Makerules	Sun, 31 May 1998 11:03:18 -0400 zack  Z.6(w)
@@ -219,12 +219,6 @@
 load-map-file = $(map-file:%=-Wl,--version-script=%)
 endif
 
-# Pattern rule to build a shared object from an archive of PIC objects.
-# $(LDLIBS-%.so) may contain -l switches to generate run-time dependencies
-# on other shared objects.
-lib%.so: lib%_pic.a $(+preinit) $(+postinit) $(+interp)
-	$(build-shlib)
-
 define build-shlib
 $(LINK.o) -shared -o $@ $(sysdep-LDFLAGS) $(config-LDFLAGS)  \
 	  -B$(csu-objpfx) $(load-map-file) \
============================================================
Index: extra-lib.mk
--- extra-lib.mk	Sun, 10 May 1998 21:50:42 -0400 zack  Z.6
+++ extra-lib.mk	Sun, 31 May 1998 09:51:25 -0400 zack  Z.6(w)
@@ -38,6 +38,12 @@
 # because linking it will depend on libc.so already being built.
 ifneq (,$(filter .os,$(object-suffixes-$(lib))))
 others: $(objpfx)$(lib).so$($(lib).so-version)
+
+# We put an explicit rule to build it here, rather than using
+# a pattern rule in Makerules, because that pattern rule can get used
+# erroneously to rebuild libc.so.
+$(objpfx)$(lib).so: $(objpfx)$(lib)_pic.a $(+preinit) $(+postinit) $(+interp)
+	$(build-shlib)
 endif
 
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]