This is the mail archive of the libc-hacker@sourceware.cygnus.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: imacros


>>>>> Andreas Jaeger writes:

>>>>> Ulrich Drepper writes:
>> I've reverted the imacro change introduced by one of Zack's patches.
>> It simply has too many weird effects.  E.g., while compiling rpcinfo.c
>> the macro __GNU_LIBRARY__ was not defined.  This should not happen.
Andreas> You only reverted part of it.  As far as I understand the issues, the
Andreas> problem of not defining __GNU_LIBRARY__ is the missing inclusion of
Andreas> <features.h> in libc-symbols.h.  <features.h> was indirectly included
Andreas> via libintl.h and you only reverted the Makeconfig part:

Andreas> 1999-06-18  Zack Weinberg  <zack@rabi.columbia.edu>

Andreas>         * include/libintl.h: Declare _libc_intl_domainname here.
Andreas>         Define _ and N_ here.
Andreas>         * include/libc-symbols.h: Don't include <libintl.h>.  Don't
Andreas>         define _ and N_.  Don't declare _libc_intl_domainname.
Andreas>         * Makeconfig (CPPFLAGS): Use -imacros to read libc-symbols.h.

Andreas> I just looked at rpcinfo and it still has __GNU_LIBRARY__ not defined
Andreas> when including getopt.h.

Here's a patch to implement my suggestions.

1999-06-22  Andreas Jaeger  <aj@arthur.rhein-neckar.de>

	* include/libc-symbols.h: Include <features.h> to fix some
	problems with the 1999-06-18 change (undefined __GNU_LIBRARY__).

--- include/libc-symbols.h.~1~	Sun Jun 20 08:52:01 1999
+++ include/libc-symbols.h	Tue Jun 22 08:26:45 1999
@@ -1,6 +1,6 @@
 /* Support macros for making weak and strong aliases for symbols,
    and for using symbol sets and linker warnings with GNU ld.
-   Copyright (C) 1995, 1996, 1997, 1998 Free Software Foundation, Inc.
+   Copyright (C) 1995, 1996, 1997, 1998, 1999 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -321,4 +321,9 @@
   strong_alias(real, name)
 #endif
 
+/* A lot of files in the GNU C library check for example
+   __GNU_LIBRARY__.  Include <features.h> to define it and the other
+   macros.  */
+#include <features.h>
+
 #endif /* libc-symbols.h */


-- 
 Andreas Jaeger   aj@arthur.rhein-neckar.de    jaeger@informatik.uni-kl.de
  for pgp-key finger ajaeger@aixd1.rhrk.uni-kl.de

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]