This is the mail archive of the libc-hacker@sourceware.cygnus.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: A getxxx_r version patch

   Date: Fri, 9 Jul 1999 16:28:52 -0700 (PDT)
   From: hjl@varesearch.com (H.J. Lu)

   Since we changed the return value of getxxx_r, I added a new version
   for each function and kept the old one.

I think you should also set errno since the new functions do not
necessarily do this.  The whole point of having getXXbyYY_r returning
the error value is avoiding the use of thread-specific data.

So instead of:

   if (ret != 0)
     ret = -1;

we should use

   if (ret != 0)
     {
       __set_errno (ret);
       ret = -1;
     }

Mark
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]