This is the mail archive of the libc-hacker@sourceware.cygnus.com mailing list for the glibc project.
Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Some of glibc's Makefiles contain flags to disable warning messages for some files. But since the introduction of those flags, the files have been changed and sometimes the disabling is not necessary anymore. I checked if those still are needed and append a patch for those which can be removed (tested with gcc 2.95.2 and egcs 1.1.2). I've also patched regex.c to remove some really unused variables. What's the philosophy about -Wno-uninitialized? gcc 2.95.2 seems to give less warnings than egcs. Some further flags can be removed if we would use gcc 2.95.2 as reference. Andreas 2000-02-25 Andreas Jaeger <aj@suse.de> * stdio-common/Makefile (CFLAGS-_itoa.c): The code has been fixed, we don't need to disable the warnings anymore, remove them. * elf/Makefile (CFLAGS-dl-load.c): Likewise. * posix/Makefile (CFLAGS-regex.c): Remove not needed warning flag. * posix/regex.c (regex_compile): Remove unused variables. ============================================================ Index: stdio-common/Makefile --- stdio-common/Makefile 2000/01/29 02:50:51 1.48 +++ stdio-common/Makefile 2000/02/25 14:38:31 @@ -59,7 +59,6 @@ include ../Rules CFLAGS-vfprintf.c = -Wno-uninitialized -CFLAGS-_itoa.c = -Wno-unused CFLAGS-tst-printf.c = -Wno-format CFLAGS-tstdiomisc.c = -Wno-format CFLAGS-scanf4.c = -Wno-format ============================================================ Index: elf/Makefile --- elf/Makefile 1999/12/04 07:54:08 1.141 +++ elf/Makefile 2000/02/25 14:38:31 @@ -153,7 +153,6 @@ $(move-if-change) ${@:st=T} ${@:st=h} touch $@ CPPFLAGS-dl-load.c = -I$(objpfx). -CFLAGS-dl-load.c += -Wno-uninitialized ifeq (yes,$(build-shared)) $(inst_slibdir)/$(rtld-version-installed-name): $(objpfx)ld.so $(+force) ============================================================ Index: posix/Makefile --- posix/Makefile 2000/01/18 01:46:27 1.86 +++ posix/Makefile 2000/02/25 14:38:31 @@ -91,7 +91,7 @@ endif endif -CFLAGS-regex.c = -Wno-unused -Wno-strict-prototypes -DDEBUG +CFLAGS-regex.c = -Wno-strict-prototypes -DDEBUG CFLAGS-getaddrinfo.c = -DRESOLVER $(objpfx)libposix.a: $(dep-dummy-lib); $(make-dummy-lib) ============================================================ Index: posix/regex.c --- posix/regex.c 2000/02/22 08:49:27 1.68 +++ posix/regex.c 2000/02/25 14:38:39 @@ -2448,7 +2448,6 @@ const int32_t *indirect; int32_t idx; const unsigned char *cp = str; - int32_t weight; int ch; /* This #include defines a local function! */ @@ -2584,11 +2583,8 @@ const unsigned char *extra; int32_t idx; int32_t elem; - const unsigned char *cp = str; - int32_t weight; int32_t second; int32_t hash; - int ch; table_size = _NL_CURRENT_WORD (LC_COLLATE, -- Andreas Jaeger SuSE Labs aj@suse.de private aj@arthur.rhein-neckar.de
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |