This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] Fix getconf LFS_CFLAGS on 64bit arches


Jakub Jelinek <jakub@redhat.com> writes:

> Hi!
> 
> Addition of _CS_V6_WIDTH_RESTRICTED_ENVS broke getconf LFS_CFLAGS on
> __WORDSIZE==64 targets because the case used to fall through to the
> string=""; string_len = 1; cases, while now getconf LFS_CFLAGS returns
> _POSIX_V6_LP64_OFF64. I believe a FALLTHROUGH comment should be sufficient
> to protect this from future breakages, though adding
> #else
>       string = "";
>       string_len = 1;
>       break;
> before _CS_LFS_CFLAGS's #endif is certainly an option as well (the compiler
> should merge the two identical case handlers anyway).

Your patch looks fine, I've committed it.

Thanks,
Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]