This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: [PATCH] dl_next_phdr (was Re: fde-glibc.c bug)

To: Jakub Jelinek <jakub at redhat dot com>
Subject: Re: [PATCH] dl_next_phdr (was Re: fde-glibc.c bug)
From: Ulrich Drepper <drepper at redhat dot com>
Date: 11 Jul 2001 11:08:56 -0700
Cc: Richard Henderson <rth at redhat dot com>, jes at sunsite dot dk, Glibc hackers <libc-hacker at sources dot redhat dot com>
References: <d3pubkfymm.fsf@lxplus015.cern.ch><200107020854.f628sOS01676@jeswick.caldera.de><20010702055546.I32061@devserv.devel.redhat.com><d3ofr3uj0v.fsf@lxplus015.cern.ch> <m3g0cf81ne.fsf@otr.mynet><20010702175906.O32061@devserv.devel.redhat.com><m38zi77zrc.fsf@otr.mynet><20010703052922.Q32061@devserv.devel.redhat.com><20010703094940.A25128@redhat.com><20010711200753.G899@sunsite.ms.mff.cuni.cz>
Reply-To: drepper at cygnus dot com (Ulrich Drepper)

Jakub Jelinek <jakub@redhat.com> writes:

> How about this?
> This one does not have callback, but of course can be easily changed into
> one if that is desired.

This is not good.  The reason to use a callback function is for the
caller (i.e., this new function) to allocate the memory for the data
structure which is passed.  This way the implementation can extend the
data structure without having compatibility problems.  The callback
should take a pointer to a data structure and a parameter with the
size.

> It does not do any locking (yet), but AFAIC dlsym and other
> functions don't do any locking either.

dlopen does locking.  dlsym doesn't have to.  If you call dlsym while
unloading the object it's your own fault.

-- 
---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------

Follow-Ups:
- [PATCH] dl_iterate_phdr
  - From: Jakub Jelinek

References:
- [PATCH] dl_next_phdr (was Re: fde-glibc.c bug)
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]