This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.
Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Thanks, I've applied the patch. I've added a few modifications. The test case shouldn't fail if the system doesn't implement SysV pseudo terminals. And there is a special function to get the master terminal file descriptor. I appreciate using __builtin_expect but it should only be used at the conditional which recognizes a failure condition. Inside the block handling the failure it's normally not necessary (we don't optimize for failures). So I moved the __builtin_expect in your grantpt patch a bit. -- ---------------. ,-. 1325 Chesapeake Terrace Ulrich Drepper \ ,-------------------' \ Sunnyvale, CA 94089 USA Red Hat `--' drepper at redhat.com `------------------------
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |