This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: fix .../linux/errlist.c


On Sun, 2002-05-19 at 09:38, Andreas Jaeger wrote:
>ware; you can redistribute it and/or
> @@ -37,8 +37,8 @@ extern const char *const *__old_sys_errl
>  
>  const int __old_sys_nerr = OLD_ERRLIST_SIZE;
>  
> -strong_alias (__old_sys_nerr, _old_sys_nerr);
>  weak_alias (__old_sys_nerr, _old_sys_nerr)
> +strong_alias (__old_sys_nerr, _old_sys_nerr);

This doesn't look OK?  Why is there a weak and a strong alias for the
same pair of names?  Please test this patch:

Index: errlist.c
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/unix/sysv/linux/errlist.c,v
retrieving revision 1.8
diff -d -u -p -r1.8 errlist.c
--- errlist.c	6 Jul 2001 04:56:12 -0000	1.8
+++ errlist.c	20 May 2002 06:40:44 -0000
@@ -1,4 +1,4 @@
-/* Copyright (C) 1998, 2000 Free Software Foundation, Inc.
+/* Copyright (C) 1998, 2000, 2002 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -38,10 +38,9 @@ extern const char *const *__old_sys_errl
 const int __old_sys_nerr = OLD_ERRLIST_SIZE;
 
 strong_alias (__old_sys_nerr, _old_sys_nerr);
-weak_alias (__old_sys_nerr, _old_sys_nerr)
 compat_symbol (libc, __old_sys_nerr, _sys_nerr, GLIBC_2_0);
 compat_symbol (libc, _old_sys_nerr, sys_nerr, GLIBC_2_0);
-weak_alias (__old_sys_errlist, _old_sys_errlist);
+strong_alias (__old_sys_errlist, _old_sys_errlist);
 compat_symbol (libc, __old_sys_errlist, _sys_errlist, GLIBC_2_0);
 compat_symbol (libc, _old_sys_errlist, sys_errlist, GLIBC_2_0);
 #endif


-- 
---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------

Attachment: signature.asc
Description: This is a digitally signed message part


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]