This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Fix isomac failure


On Thu, Aug 01, 2002 at 11:32:29PM -0400, Roland McGrath wrote:
> I have just checked in some changes to make libc use TLS internally when
> __thread is available (along with some fixes to the TLS support code).  All
> available tools that claim to support TLS have bugs that will louse up your
> libc build, so be sure to configure using --without-tls if you have tools
> that claim to support TLS and __thread.

Even with --without-tls, this breaks make check - stdlib/isomac test fails
with:
Tested files:
assert.h
ctype.h
errno.h
#define BUSY_WAIT_NOP __asm__ ("rep; nop")
#define HAS_COMPARE_AND_SWAP
#define PT_EI extern inline
#define CURRENT_STACK_FRAME __builtin_frame_address (0)
float.h
iso646.h
limits.h
locale.h
math.h
setjmp.h
signal.h
stdarg.h
stddef.h
stdio.h
stdlib.h
string.h
time.h
wchar.h
wctype.h

In reality this is not a problem, since tls.h which brings all the above
stuff in is included in include/errno.h only, ie. private header.
The following patch should shut up make check:

2002-08-02  Jakub Jelinek  <jakub@redhat.com>

	* include/errno.h: Don't include tls.h if _ISOMAC is defined.

--- libc/include/errno.h.jj	2002-08-02 11:47:37.000000000 +0200
+++ libc/include/errno.h	2002-08-02 22:01:08.000000000 +0200
@@ -2,7 +2,7 @@
 
 #include <stdlib/errno.h>
 
-#ifdef _ERRNO_H
+#if defined _ERRNO_H && !defined _ISOMAC
 
 # include <tls.h>		/* Defines USE_TLS.  */
 
	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]