This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH] Fix dl-environ.c

From: Jakub Jelinek <jakub at redhat dot com>
To: Ulrich Drepper <drepper at redhat dot com>, Roland McGrath <roland at redhat dot com>
Cc: Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Wed, 11 Sep 2002 23:54:02 +0200
Subject: [PATCH] Fix dl-environ.c
Reply-to: Jakub Jelinek <jakub at redhat dot com>

Hi!

ld.so has apparently been too aggressive when removing variables
from environment, particularly it removed all the unsecure envvars (as
it should) plus all its prefixes, ie. it removed
LOCALDOMAIN, but e.g. LOCALDOMAI, LOCAL, LOCA, LO or L variables too.

2002-09-11  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/generic/dl-environ.c (unsetenv): Only remove variables fully
	matching name.

--- libc/sysdeps/generic/dl-environ.c.jj	2002-03-23 11:51:04.000000000 +0100
+++ libc/sysdeps/generic/dl-environ.c	2002-09-11 22:53:42.000000000 +0200
@@ -67,7 +67,7 @@ unsetenv (const char *name)
       while ((*ep)[cnt] == name[cnt] && name[cnt] != '\0')
 	++cnt;
 
-      if ((*ep)[cnt] == '=')
+      if ((*ep)[cnt] == '=' && name[cnt] == '\0')
 	{
 	  /* Found it.  Remove this pointer by moving later ones to
 	     the front.  */

	Jakub

Follow-Ups:
- Re: [PATCH] Fix dl-environ.c
  - From: Roland McGrath

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]