This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix tst-aio7.

From: Ulrich Drepper <drepper at redhat dot com>
To: Roland McGrath <roland at redhat dot com>
Cc: libc-hacker at sources dot redhat dot com
Date: Thu, 06 Mar 2003 11:57:23 -0800
Subject: Re: [PATCH] Fix tst-aio7.
Organization: Red Hat, Inc.
References: <200303061937.h26JbgT21780@magilla.sf.frob.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Roland McGrath wrote:

> How so?  The test looks clearly wrong to me.  aio_suspend will return when
> the CB0 request is done, and the CB1 request is still outstanding.  Unless
> we synchronize with that request, CB1 is still in the aio data structures
> when it is no longer live on the stack.

Then these variables have to have global scope.

The test in question was also testing that the AIO handling at exit time
is leak-free.  There is not explicit test but one easily sees system
resources being depleated.  This is important once we have a
kernel-supported AIO implementation.

- -- 
- --------------.                        ,-.            444 Castro Street
Ulrich Drepper \    ,-----------------'   \ Mountain View, CA 94041 USA
Red Hat         `--' drepper at redhat.com `---------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+Z6gj2ijCOnn/RHQRAiM/AKCMnrRh33tGLQtD4OX/25RZUY/YPACgof8+
1u4fOGGrnW8cD7ftE0vbQ14=
=FNCu
-----END PGP SIGNATURE-----

Follow-Ups:
- Re: [PATCH] Fix tst-aio7.
  - From: Roland McGrath

References:
- Re: [PATCH] Fix tst-aio7.
  - From: Roland McGrath

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]