Re: [PATCH] PPC enable Alitvec hardware, part 1

[Andreas Jaeger <aj at suse dot de>]

Steve Munroe <sjmunroe@us.ibm.com> writes:

> +/* from linux/asm/cputable.h.  */
> +#define PPC_FEATURE_32                  0x80000000
> +#define PPC_FEATURE_64                  0x40000000
> +#define PPC_FEATURE_601_INSTR           0x20000000
> +#define PPC_FEATURE_HAS_ALTIVEC         0x10000000
> +#define PPC_FEATURE_HAS_FPU             0x08000000
> +#define PPC_FEATURE_HAS_MMU             0x04000000
> +#define PPC_FEATURE_HAS_4xxMAC          0x02000000
> +#define PPC_FEATURE_UNIFIED_CACHE       0x01000000

Please add comments here.
> +#ifndef SHARED
> +  __has_altivec=((GL(dl_hwcap) & PPC_FEATURE_HAS_ALTIVEC) ? 1:0);

According to the GNU Coding standards this should have some more
whitespace, e.g.:
__has_altivec = ((GL (dl_hwcap) & PPC_FEATURE_HAS_ALTIVEC) ? 1 : 0);

Please rewrite your patch to follow the Coding standards everywhere...

> +#endif
>    return generic_start_main (stinfo->main, argc, ubp_av, auxvec,
>  			     stinfo->init, stinfo->fini, rtld_fini,
>  			     stack_on_entry);
> diff -urN libc23-cvstip-20040102/sysdeps/powerpc/longjmp.c libc23/sysdeps/powerpc/longjmp.c
> --- libc23-cvstip-20040102/sysdeps/powerpc/longjmp.c	Wed Dec 31 18:00:00 1969
> +++ libc23/sysdeps/powerpc/longjmp.c	Sat Jan 10 11:29:58 2004
> @@ -0,0 +1,56 @@
> +/* Copyright (C) 1991,92,94,95,97,98,2000,2002 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.
> +
> +   The GNU C Library is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU Lesser General Public
> +   License as published by the Free Software Foundation; either
> +   version 2.1 of the License, or (at your option) any later version.
> +
> +   The GNU C Library is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +   Lesser General Public License for more details.
> +
> +   You should have received a copy of the GNU Lesser General Public
> +   License along with the GNU C Library; if not, write to the Free
> +   Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
> +   02111-1307 USA.  */
> +/*
> +  Versioned copy of sysdeps/generic/longjmp.c modified for altivec support.
> + */

This is not a properly formatted comment.

> +#include  <shlib-compat.h>
> +#include <stddef.h>
Just one space everywhere.

> +#include <setjmp.h>
> +#include <signal.h>
> +
> +#if defined(NOT_IN_libc) || !defined(SHARED)
> +/* We don't want this variable both in ld.so & libc.so as
> +   we would then have duplicate variable linker confusion.  */
> +int vec__has_altivec=0;
> +default_symbol_version (vec__has_altivec,__has_altivec,GLIBC_2.3.4);
> [...]

Missing whitespace again.

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature