This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix AMD64 backtrace

From: Jakub Jelinek <jakub at redhat dot com>
To: Andreas Jaeger <aj at suse dot de>
Cc: Ulrich Drepper <drepper at redhat dot com>, Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Mon, 12 Jan 2004 08:51:35 +0100
Subject: Re: [PATCH] Fix AMD64 backtrace
References: <20040108134216.GE6413@sunsite.ms.mff.cuni.cz> <m33candbth.fsf@gromit.moeb>
Reply-to: Jakub Jelinek <jakub at redhat dot com>

On Sat, Jan 10, 2004 at 05:10:18PM +0100, Andreas Jaeger wrote:
> --- sysdeps/unix/sysv/linux/x86_64/__start_context.S	27 Aug 2003 23:03:41 -0000	1.2
> +++ sysdeps/unix/sysv/linux/x86_64/__start_context.S	10 Jan 2004 16:09:40 -0000
> @@ -1,4 +1,4 @@
> -/* Copyright (C) 2002, 2003 Free Software Foundation, Inc.
> +/* Copyright (C) 2002, 2003, 2004 Free Software Foundation, Inc.
>     This file is part of the GNU C Library.
>     Contributed by Andreas Jaeger <aj@suse.de>, 2002.
>  
> @@ -33,6 +33,7 @@ ENTRY(__start_context)
>  	movq	%rbx, %rsp

This is not reflected in the unwind info.
Unless %rbx points to a populated stack with correct caller
something needs to be done about it.

> --- sysdeps/x86_64/strcspn.S	29 Apr 2003 22:47:18 -0000	1.2
> +++ sysdeps/x86_64/strcspn.S	10 Jan 2004 16:09:41 -0000
> @@ -1,7 +1,7 @@
>  /* strcspn (str, ss) -- Return the length of the initial segment of STR
>  			which contains no characters from SS.
>     For AMD x86-64.
> -   Copyright (C) 1994-1997, 2000, 2002, 2003 Free Software Foundation, Inc.
> +   Copyright (C) 1994-1997, 2000, 2002, 2003, 2004 Free Software Foundation, Inc.
>     This file is part of the GNU C Library.
>     Contributed by Ulrich Drepper <drepper@gnu.ai.mit.edu>.
>     Bug fixes by Alan Modra <Alan@SPRI.Levels.UniSA.Edu.Au>.
> @@ -40,6 +40,7 @@ ENTRY (strcspn)
>  	   table.  */
>  	movq %rdi, %r8			/* Save value.  */
>  	subq $256, %rsp			/* Make space for 256 bytes.  */
> +	cfi_adjust_cfa_offset(-256)

Typo/pasto.

	Jakub

Follow-Ups:
- Re: [PATCH] Fix AMD64 backtrace
  - From: Andreas Jaeger

References:
- [PATCH] Fix AMD64 backtrace
  - From: Jakub Jelinek
- Re: [PATCH] Fix AMD64 backtrace
  - From: Andreas Jaeger

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]