This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] <bits/string2.h> changes for GCC 3.2+ and 3.4+ (followup)

From: Jakub Jelinek <jakub at redhat dot com>
To: "H. J. Lu" <hjl at lucon dot org>
Cc: Ulrich Drepper <drepper at redhat dot com>, Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Fri, 28 May 2004 08:27:08 +0200
Subject: Re: [PATCH] <bits/string2.h> changes for GCC 3.2+ and 3.4+ (followup)
References: <20040526124659.GT5191@sunsite.ms.mff.cuni.cz> <40B4D342.3060301@redhat.com> <20040526203623.GA3779@lucon.org> <20040527010102.GA8045@lucon.org> <20040527071240.GU5191@sunsite.ms.mff.cuni.cz> <20040527151606.GA21690@lucon.org>
Reply-to: Jakub Jelinek <jakub at redhat dot com>

On Thu, May 27, 2004 at 08:16:06AM -0700, H. J. Lu wrote:
> On Thu, May 27, 2004 at 09:12:40AM +0200, Jakub Jelinek wrote:
> > On Wed, May 26, 2004 at 06:01:02PM -0700, H. J. Lu wrote:
> > > I think the patch is incomplete. 
> > 
> > You are right, sorry.  I haven't built glibc with it after doing all changes,
> > only tested whether apps using that header are ok.
> > Further testing revealed that at least on x86_64 there was one new
> > .plt slot, __bzero.  This patch fixes that too.
> > Build/make check tested on x86_64 and i686.
> > 
> 
> You also need to add __bzero to sysdeps/ia64/bzero.S.

FYI I've just built CVS glibc on i386/i686/x86_64/ia64/ppc/ppc64/s390/s390x
and did not have problems.

__bzero can be added to ia64/bzero.S for consistency, but AFAIK nothing will
use it.

	Jakub

References:
- [PATCH] <bits/string2.h> changes for GCC 3.2+ and 3.4+
  - From: Jakub Jelinek
- Re: [PATCH] <bits/string2.h> changes for GCC 3.2+ and 3.4+
  - From: Ulrich Drepper
- Re: [PATCH] <bits/string2.h> changes for GCC 3.2+ and 3.4+
  - From: H. J. Lu
- Re: [PATCH] <bits/string2.h> changes for GCC 3.2+ and 3.4+
  - From: H. J. Lu
- [PATCH] <bits/string2.h> changes for GCC 3.2+ and 3.4+ (followup)
  - From: Jakub Jelinek
- Re: [PATCH] <bits/string2.h> changes for GCC 3.2+ and 3.4+ (followup)
  - From: H. J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]