This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH] Fix pthread_spin_unlock on ia64

From: Jakub Jelinek <jakub at redhat dot com>
To: Ulrich Drepper <drepper at redhat dot com>
Cc: Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Mon, 30 Oct 2006 01:26:45 +0100
Subject: [PATCH] Fix pthread_spin_unlock on ia64
Reply-to: Jakub Jelinek <jakub at redhat dot com>

Hi!

__sync_lock_release_si was an implementation detail of the old
<ia64intrin.h>'s __sync_lock_release macro.  GCC 4.1.x+ supports
only __sync_lock_release.
Now the question is why this hasn't been seen before, I think perhaps
nptl/sysdeps/pthread could be searched before nptl/sysdeps/ia64.

2006-10-30  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/ia64/pthread_spin_unlock.c (pthread_spin_unlock): Use
	__sync_lock_release instead of __sync_lock_release_si.

--- libc/nptl/sysdeps/ia64/pthread_spin_unlock.c	2003-03-18 04:42:45.000000000 +0100
+++ libc/nptl/sysdeps/ia64/pthread_spin_unlock.c	2006-10-30 00:31:16.000000000 +0100
@@ -1,4 +1,4 @@
-/* Copyright (C) 2003 Free Software Foundation, Inc.
+/* Copyright (C) 2003, 2006 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
    Contributed by Jakub Jelinek <jakub@redhat.com>, 2003.
 
@@ -23,6 +23,6 @@
 int
 pthread_spin_unlock (pthread_spinlock_t *lock)
 {
-  __sync_lock_release_si ((int *) lock);
+  __sync_lock_release ((int *) lock);
   return 0;
 }

	Jakub

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]