This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Fix last svc_run change


On Mon, Nov 27, 2006 at 08:10:41PM +0100, Jakub Jelinek wrote:
> 2006-11-27  Jakub Jelinek  <jakub@redhat.com>
> 
> 	[BZ #3559]
> 	* sunrpc/svc_run.c (svc_run): Fail instead of segfaulting if
> 	malloc crashed.  Don't allocate memory unnecessarily in each
> 	loop.

Oops, brown paper bag bug in it, fixed thusly, tested with portmap:

2006-11-30  Jakub Jelinek  <jakub@redhat.com>

	* sunrpc/svc_run.c (svc_run): Set my_pollfd to new_pollfd if realloc
	succeeded.

--- libc/sunrpc/svc_run.c	27 Nov 2006 21:58:11 -0000	1.11
+++ libc/sunrpc/svc_run.c	30 Nov 2006 13:41:18 -0000
@@ -71,6 +71,7 @@ svc_run (void)
 	      break;
 	    }
 
+	  my_pollfd = new_pollfd;
 	  last_max_pollfd = max_pollfd;
 	}
 


	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]