This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PPC fenv fixes.


Jakub Jelinek wrote:
> On Tue, Mar 27, 2007 at 11:09:28AM -0500, Steven Munroe wrote:
>   
>> 2007-03-26  Steven Munroe  <sjmunroe@us.ibm.com>
>>
>> 	* sysdeps/powerpc/fpu/feupdateenv.c: Change mask to merge exceptions
>> 	from env.
>>     
>
> Will that actually raise SIGFPE signals when exceptions are enabled?
> From my reading of POSIX that's what should happen with the
> `old' exceptions (and other arches are calling feraiseexcept that will do
> that).  I didn't add a testcase for it because I'm not 100% sure about that.
>
>   
hmmm not unless the SIGFPE is eanbled by the MSR FE bits. So we will
need to call __fe_nomask_env() in feupdateenv similar to what we do in
feenableexcept(). Probably should add the __fe_mask_env() call for when
the application remasks FP exceptions. This allows the hardware to run
faster when we are taking the default action.

I will rework the patch.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]