This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] PPC fenv fixes.

From: Richard Henderson <rth at twiddle dot net>
To: Steven Munroe <munroesj at us dot ibm dot com>
Cc: Jakub Jelinek <jakub at redhat dot com>, Glibc hackers <libc-hacker at sources dot redhat dot com>, Ulrich Drepper <drepper at redhat dot com>, Peter Eberlein <eberlein at us dot ibm dot com>
Date: Wed, 4 Apr 2007 19:26:55 -0700
Subject: Re: [PATCH] PPC fenv fixes.
References: <20070322145345.GZ1826@sunsite.mff.cuni.cz> <4602FCE5.7060203@us.ibm.com> <460941B8.2050501@us.ibm.com> <20070327160708.GA355@devserv.devel.redhat.com> <46096124.6050504@us.ibm.com> <460A8D78.6060303@us.ibm.com>

On Wed, Mar 28, 2007 at 10:44:56AM -0500, Steven Munroe wrote:
>     performance penalty (but have no other visible effect).  */
>  extern const fenv_t *__fe_nomask_env (void);
>  # define FE_NOMASK_ENV	(__fe_nomask_env ())
> +
> +/* Floating-point environment with all exceptions disabled.  */
> +extern const fenv_t *__fe_mask_env (void);
> +# define FE_MASK_ENV	(__fe_mask_env ())

This is incorrect.  The mere evaluation of FE_NOMASK_ENV/FE_MASK_ENV
should have no effect at all.  This stuff should be delayed until
the environment is actually installed.

You should be using magic numbers, like in the i386 port.

r~

Follow-Ups:
- [PATCH] PPC fenv fixes. 3rd update
  - From: Steven Munroe

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]