This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.
Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
In our bugzilla we got a report that an extern is missing (for details: https://bugzilla.novell.com/show_bug.cgi?id=233835). This results on static linking with -Wl,-warn-common in lots of these warnings: /usr/lib64/gcc/x86_64-suse-linux/4.1.2/../../../../lib64/libc.a(strtod_l.o): warning: common of `_nl_category_name_idxs' overridden by definition /usr/lib64/gcc/x86_64-suse-linux/4.1.2/../../../../lib64/libc.a(setlocale.o): warning: defined here /usr/lib64/gcc/x86_64-suse-linux/4.1.2/../../../../lib64/libc.a(mbrtowc.o): warning: multiple common of `_nl_category_name_idxs' Ok to commit? Andreas 2007-08-16 Andreas Jaeger <aj@suse.de> * locale/localeinfo.h: Make _nl_category_name_idxs extern. Reported by Peter Festner <peter.festner@ewetel.net>. Index: locale/localeinfo.h =================================================================== RCS file: /cvs/glibc/libc/locale/localeinfo.h,v retrieving revision 1.59 diff -u -p -r1.59 localeinfo.h --- locale/localeinfo.h 27 Oct 2006 23:11:43 -0000 1.59 +++ locale/localeinfo.h 16 Aug 2007 06:52:15 -0000 @@ -186,7 +186,7 @@ extern const union catnamestr_t }; char str[0]; } _nl_category_names attribute_hidden; -const uint8_t _nl_category_name_idxs[__LC_LAST] attribute_hidden; +extern const uint8_t _nl_category_name_idxs[__LC_LAST] attribute_hidden; extern const uint8_t _nl_category_name_sizes[__LC_LAST] attribute_hidden; /* Name of the standard locales. */ -- Andreas Jaeger, Director Platform / openSUSE, aj@suse.de SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) Maxfeldstr. 5, 90409 Nürnberg, Germany GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
Attachment:
pgp00000.pgp
Description: PGP signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |